Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Add a FFI accessor to incoming proxy protocol values #14664

Merged
merged 4 commits into from
Sep 30, 2024

Conversation

rgacogne
Copy link
Member

@rgacogne rgacogne commented Sep 12, 2024

Short description

Needs:

  • manual testing
  • unit tests
  • regression tests
Fixes https://github.com//issues/14656

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@coveralls
Copy link

coveralls commented Sep 12, 2024

Pull Request Test Coverage Report for Build 11033773952

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 58 of 60 (96.67%) changed or added relevant lines in 2 files are covered.
  • 1179 unchanged lines in 19 files lost coverage.
  • Overall coverage decreased (-0.03%) to 64.679%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pdns/dnsdistdist/dnsdist-lua-ffi.cc 16 18 88.89%
Files with Coverage Reduction New Missed Lines %
pdns/dnsdistdist/dnsdist-crypto.cc 1 76.01%
pdns/misc.cc 1 63.26%
pdns/version.cc 3 95.57%
pdns/libssl.cc 3 59.01%
pdns/remote_logger.cc 3 53.36%
modules/gpgsqlbackend/spgsql.cc 3 67.7%
pdns/signingpipe.cc 5 83.11%
pdns/dnsdistdist/dnsdist-carbon.cc 6 62.16%
pdns/recursordist/syncres.cc 7 79.37%
pdns/packethandler.cc 8 72.69%
Totals Coverage Status
Change from base Build 10882883877: -0.03%
Covered Lines: 124835
Relevant Lines: 162282

💛 - Coveralls

@rgacogne rgacogne force-pushed the ddist-ffi-proxy-protocol-incoming branch from 7fa913f to 887c333 Compare September 17, 2024 08:53
@rgacogne rgacogne marked this pull request as ready for review September 17, 2024 08:53
pdns/dnsdistdist/dnsdist-lua-ffi.cc Outdated Show resolved Hide resolved
pdns/dnsdistdist/dnsdist-lua-ffi.cc Outdated Show resolved Hide resolved
@rgacogne rgacogne merged commit 3f0cb1a into PowerDNS:master Sep 30, 2024
79 checks passed
@rgacogne rgacogne deleted the ddist-ffi-proxy-protocol-incoming branch September 30, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants