Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add S3 SSE-C Support #58

Closed
wants to merge 1 commit into from
Closed

Add S3 SSE-C Support #58

wants to merge 1 commit into from

Conversation

udf2457
Copy link
Contributor

@udf2457 udf2457 commented Oct 3, 2023 •
edited
Loading

Code to add S3 SSE-C Support #52

Was originally PR #54, but I made a mess of that fork. So this is based off a clean fork with the code in its own branch to keep it clean.

@udf2457
Add S3 SSE-C Support
598a8d0 
Code to add S3 SSE-C Support
@udf2457 udf2457 mentioned this pull request Oct 3, 2023
Open
wojas
wojas requested changes Oct 4, 2023
View reviewed changes
Copy link
Member

@wojas wojas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reuses a single static key for every file, which makes it relatively easy to intercept the key and use it to decrypt every file, severely weakening any protection this would provide.

See #52 for details.

@udf2457 udf2457 closed this by deleting the head repository Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojas wojas wojas requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@udf2457 @wojas