186 open snapshot in editor #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sync with official fork v1.7.0
This commit implements issue Raathigesh#186. I can't know if there is a snapshot for each but I can add a button to the summary that opens the snapshot for the file in the code editor. That's what this commit does. It adds the button to the UI and a mutation to send to the server to open the snapshot in the editor. And it implements issue Raathigesh#191. There was already a button for generating a snapshot, but it was only visible when there was a detected snapshot error. This caused us to have to run known failing tests before we could get the button to generate the snapshots. Now the button is there all the time, so if you know your snapshots are out of date, then you can generate them immediately and save time.
Raathigesh
reviewed
May 18, 2020
|
If you could help with the merge conflict, I can get this merged as well and release a new version by this week. |
|
@Raathigesh sorry, I don't know how those became merge conflicts and GitHub didn't suggest the proper merge for one of them. I have resolved the conflicts now with the code that should be there. |
|
Thanks for this as well. Looks good. I'm planning to a sanity test this weekend and will do a release with all your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things. It implements #186 and #191.
For #186, this creates a new button to load the snapshot in the editor so that you can quickly
see the snapshot - useful when writing tests.
I had created FR #191 because I wanted a way to generate the snapshots, not realizing that the
button was already there. This change makes the button visible all the time. The reason for that
is that there are times when you know the snapshots are out of date and need to be updated.
If you run the tests just to have them fail, it wastes time. Having this button visible all the time
saves time because you can generate the snapshots when you know they are out of date.