fix(TomlTable): fixes key serialization by adding better key name checks #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cks 729f57 Closes SamboyCoding#30 Closes SamboyCoding#31
tcortega
force-pushed
the
fix/key-escaping-check
branch
from
fa17b89
to
aabe8c0
Compare
Using chars in the Contains method is not possible for every framework the project supports.
|
Can you rebase this onto latest? |
SamboyCoding
requested changes
Jul 16, 2023
SamboyCoding
approved these changes
Jul 16, 2023
SamboyCoding
added a commit
that referenced
this pull request
Mar 20, 2024
Caused by a regression in #33 that wasn't caught. Added a test to ensure it is caught in future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses a foreach to iterate through the key strings both in the table and during object serialization to identify which keys needs to be quoted in a performative way.
Also made a small optimization in the methods insideTomlUtils.The tests might not look that good, feel free to change it if you want. Or give me a heads up on what you have in mind for the tests.
Closes #30
Closes #31