Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional improvements to documentation for Storefront Api Clients troubleshooting section #1657

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

andy-liuu
Copy link
Contributor

@andy-liuu andy-liuu commented Oct 18, 2024

WHY are these changes introduced?

Because #1651 got merged early. Addressing comments that should have been in this pr

WHAT is this pull request doing?

variable renaming + added documentation

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have used pnpm changeset to create a draft changelog entry (do NOT update the CHANGELOG.md files manually)
  • I have added/updated tests for this change
  • I have documented new APIs/updated the documentation for modified APIs (for public APIs)

@andy-liuu
Copy link
Contributor Author

Skip Changelog -> it's only a documentation change

Skip Markdown Link Check -> due to test flakyness from external issues

@andy-liuu andy-liuu enabled auto-merge (squash) October 18, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants