Fix broken CI on Ruby 3.1 #2029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a test that was pointing to rails#main; however, main / Rails 8 has dropped support for Ruby 3.1 so the test started failing. The test does seem valuable so we're pointing to rails#7-2-stable instead.
KaanOzkan
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
This won't solve everything though: the CI matrix combination of ruby 3.1 + rails main will be broken.
rails main should be experimental and always passing. But if not we can skip this test in that particular setup.
EDIT: Okay the issue is experimental only plays a part in running tests and not during setup-ruby.
|
Just pushed another commit to exclude the Ruby 3.1 + Rails main combination; if CI gets green I'll merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a test that was pointing to rails#main; however, main / Rails 8 has dropped support for Ruby 3.1 so the test started failing. The test does seem valuable so we're pointing to rails#7-2-stable instead.
This won't solve everything though: the CI matrix combination of ruby 3.1 + rails main will be broken.Another option here could be to remove 3.1 from CI; this might be OK given we no longer support that version at Shopify.#2029 (comment)