Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default float type to float(Real), not Real (#685) #686

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

penelopeysm
Copy link
Member

The same as #685, just ported to the newest version.

penelopeysm and others added 2 commits October 11, 2024 15:41
* Default float type to float(Real), not Real

Closes #684

* Trigger CI on backport branches/PRs

* Add integration test for #684

* Bump Turing version to 0.34 in test subfolder
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@coveralls
Copy link

coveralls commented Oct 11, 2024

Pull Request Test Coverage Report for Build 11409929643

Details

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • 92 unchanged lines in 18 files lost coverage.
  • Overall coverage decreased (-2.1%) to 77.53%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/utils.jl 1 2 50.0%
Files with Coverage Reduction New Missed Lines %
src/model.jl 1 93.68%
src/sampler.jl 1 92.73%
ext/DynamicPPLEnzymeCoreExt.jl 1 0.0%
src/contexts.jl 3 75.76%
src/context_implementations.jl 3 63.67%
src/test_utils.jl 3 85.31%
src/model_utils.jl 3 19.64%
src/varnamedvector.jl 3 89.42%
src/distribution_wrappers.jl 4 44.12%
ext/DynamicPPLForwardDiffExt.jl 4 66.67%
Totals Coverage Status
Change from base Build 11381380435: -2.1%
Covered Lines: 3264
Relevant Lines: 4210

💛 - Coveralls

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.52%. Comparing base (54691bf) to head (e994196).

Files with missing lines Patch % Lines
src/utils.jl 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #686      +/-   ##
==========================================
- Coverage   79.22%   77.52%   -1.70%     
==========================================
  Files          30       30              
  Lines        4212     4210       -2     
==========================================
- Hits         3337     3264      -73     
- Misses        875      946      +71     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@penelopeysm
Copy link
Member Author

Obviously broken. Next week's problem!

@penelopeysm penelopeysm marked this pull request as draft October 11, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants