-
-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(linux): Emit D-Bus signal directly for dock notification badges #686
base: main
Are you sure you want to change the base?
Conversation
Closes Vencord#298, Vencord#424, Vencord#189 remove (#) title prefix when `Notification Badge` option is toggled explode scuffed option libunity dependency (kabloomed)
Applied reviewer suggestions. Unread Badge displays a `0`
I think it makes most sense to not display an unread pings badge if the count is 0. Idm either way for the • |
@ToxicMushroom The unread count isnt actually "0" in this case. Theres two distinct badge modes; unreads and mentions. Mentions are what have the number count and only shows up for pings and DMs, etc. Unreads are when there is a message in a channel that you do not have muted. Users can disable the unread badge but still have the mention badge. The reason why the unread badge shows a "0" is due to a limitation with the Launcher API it can only show 0-9 with no option for blank badge or a dot. |
Co-authored-by: vee <[email protected]>
Why gdbus? It doesn’t necessarily exist on platforms supporting this DBus API (e.g. KDE Plasma) Can you switch to a DBus node.js library? |
I think we went with cli to not bring in another dep. If the issue is gdbus not existing everywhere we could switch to dbus-send |
There are two DBus implementations: So all in all I’d say if you go with one tool, |
adds `@homebridge/dbus-native` as a dependency
Curious where this PR stands as I'd like to have this fix already so I can ditch the Official Discord Client on GNOME Wayland. |
@CarJem wait for vee to get around to merging or build and run vesktop yourself locally |
Important info: I compiled this pr and used it for some time, this makes programs crash after some time. turns out it opens dbus interfaces like crazy. I'm almost sure it happens even if you shouldn't have a badge. (as in, you don't get any ping or message). |
if the |
@RealSweetPanda I cannot replicate the dbus spam or crashing.
|
Closes #298, #424, #189
remove (#) title prefix when
Notification Badge
option is toggledexplode scuffed optional libunity dependency (kabloomed)