-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block registration: when parent is a string
cast it to array
#66250
Draft
oandregal
wants to merge
5
commits into
trunk
Choose a base branch
from
update/cast-string-parent-to-array
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+16
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
added
[Type] Bug
An existing feature does not function as intended
[Feature] Blocks
Overall functionality of blocks
[Package] Blocks
/packages/blocks
labels
Oct 18, 2024
Size Change: +47 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
Flaky tests detected in fe4e3be. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11406986399
|
oandregal
force-pushed
the
update/cast-string-parent-to-array
branch
from
October 21, 2024 08:30
fe4e3be
to
3382ce5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Blocks
Overall functionality of blocks
[Package] Blocks
/packages/blocks
[Type] Bug
An existing feature does not function as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Casts
blockType.parent
to array if it's a string.Why?
While we haven't enforced it in any way, we have been operating under the assumption that
blockType.parent
is an array. Apparently, not always is and blocks may register it using a string. When processing input from 3rd parties, we should enforce the type so it's safe to operate with it during the whole lifecycle of the block (e.g.: to avoid issues like this one).How?
blockType.parent
is a string #66234TODO
Check what other places we may need to enforce
blockType.parent
is a string #66234Testing Instructions
TBD.