Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add unit_tests for is_main_network() #7571

Open
wants to merge 6 commits into
base: trunk
Choose a base branch
from

Conversation

Debarghya-Banerjee
Copy link

Trac Ticket: Core-59981

Description:

  • This pull request introduces the initial set of unit tests for the is_main_network() function. The tests are designed to verify the function's behavior in both multisite and single-site scenarios.

Changes Made:

  • Added Multisite Tests:

    • Class: Tests_Multisite_IsMainNetwork

    • Purpose: Tests the behavior of is_main_network() for valid and invalid network IDs within a multisite environment.

    • Test Cases:

      • Valid network IDs that should return true:

        • null
        • 1 (main network)
      • Invalid network IDs that should return false:

        • 2
        • 0
        • Empty string
  • Added Single-Site Tests:

    • Class: Tests_Functions_IsMainNetwork

    • Purpose: Tests the behavior of is_main_network() in a single-site context.

    • Test Cases:

      • Valid network IDs that should return true:
        • null
        • 1
        • 0
        • Empty string
        • Non-main network ID (2) which is also tested to ensure the function handles it correctly.

Benefits:

  • Coverage for Multisite and Single-Site

    • Ensures that the is_main_network() function is thoroughly tested in different contexts.
  • Early Detection of Issues

    • The introduction of these tests will help catch any bugs or unexpected behavior early in the development process.

Testing:

  • The tests are designed to be run in the WordPress environment using PHPUnit.

  • All tests have been verified to pass successfully.

Commands

Multisite

npm run test:php -- -c tests/phpunit/multisite.xml --group ms-site --filter Tests_MultiSite_is_main_network

Single SIte

npm run test:php --filter Tests_Multisite_IsMainNetwork::test_should_return_true_for_valid_network_id

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props debarghyabanerjee.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant