Automatically apply permissions for stuff provisioned with ynh_setup_source.
#1955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zamentur
reviewed
Oct 13, 2024
helpers/helpers.v2.1.d/utils
Outdated
| chown "$app:$app" "$target" | ||
| if (is_in_dir "$target" "${install_dir:-}" || is_in_dir "$target" "${data_dir:-}" || is_in_dir "$target" "/etc/$app"); then | ||
| if [ -d "$target" ]; then | ||
| chmod -R o+rwX "$target" |
There was a problem hiding this comment.
Seems a security hole. If we do ynh_setup_source or ynh_setup_source "$install_dir" we apply here a o+rwX permission by default, but we should not allowed other users to access this dir (by default) i guess.
In more adding a -R options onto data_dir could be looooong (if there is a lot of file), so this should be done only one time by yunohost install or upgrade...
I suggest to study all chown, chmod apps to understand what should be done by default and how give advice in the right way to packagers if needed.
There was a problem hiding this comment.
It was supposed to be u not o x_x
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
ynh_setup_source "$install_dir/subpath"is excluded from default permissions$install_diris exempt from default permissions, unlike adding a file there.Solution
Subdirectories of
$install_dirand$data_dirget$app:$appo+rwXownership & permissions by default, in line with files added there.PR Status
It worked once when installing YunoHost-Apps/syncserver-rs_ynh#58
How to test
Install an app that uses helpers v2.1 (duh) and provisions sources into a subdirectory.