Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- Added CLI tools for Red Hat OpenShift on AWS #955

Closed
wants to merge 1 commit into from
Closed

- Added CLI tools for Red Hat OpenShift on AWS #955

wants to merge 1 commit into from

Conversation

mkimberley
Copy link
Contributor

Added the Red Hat OpenShift on AWS (ROSA) cli tool

Description

The ROSA cli is a command line too for administering OpenShift clusters on the managed AWS service. This merge request adds additional functionality to arkade to allow simple installation.

Motivation and Context

This allows the simple installation of the ROSA cli client tools, avoiding the process of having to log into the Red Hat portal and choose the appropriate binary from a drop down selection. Having this functionality in arkade will improve my workflow.

How Has This Been Tested?

make e2e and hack tool.

+ ./arkade get rosa --arch arm64 --os darwin --quiet
+ file /home/matt/.arkade/bin/rosa
/home/matt/.arkade/bin/rosa: Mach-O 64-bit x86_64 executable
+ rm /home/matt/.arkade/bin/rosa
+ echo

+ ./arkade get rosa --arch x86_64 --os darwin --quiet
+ file /home/matt/.arkade/bin/rosa
/home/matt/.arkade/bin/rosa: Mach-O 64-bit x86_64 executable
+ rm /home/matt/.arkade/bin/rosa
+ echo

+ ./arkade get rosa --arch x86_64 --os linux --quiet
+ file /home/matt/.arkade/bin/rosa
/home/matt/.arkade/bin/rosa: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, Go BuildID=UJy8CZP35000NA1DroaT/lO2jEUUnFH0Raz-VQItd/YE6IzU1BAWt0YE-B0f9M/7MqygW3g8mr-PRlw8ubZ, not stripped
+ rm /home/matt/.arkade/bin/rosa
+ echo

+ ./arkade get rosa --arch aarch64 --os linux --quiet
+ file /home/matt/.arkade/bin/rosa
/home/matt/.arkade/bin/rosa: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, Go BuildID=UJy8CZP35000NA1DroaT/lO2jEUUnFH0Raz-VQItd/YE6IzU1BAWt0YE-B0f9M/7MqygW3g8mr-PRlw8ubZ, not stripped
+ rm /home/matt/.arkade/bin/rosa
+ echo

+ ./arkade get rosa --arch x86_64 --os mingw --quiet
+ file /home/matt/.arkade/bin/rosa.exe
/home/matt/.arkade/bin/rosa.exe: PE32+ executable (console) x86-64 (stripped to external PDB), for MS Windows, 13 sections
+ rm /home/matt/.arkade/bin/rosa.exe
+ echo

If updating or adding a new CLI to arkade get, run:

go build && ./hack/test-tool.sh TOOL_NAME

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Documentation

  • I have updated the list of tools in README.md if (required) with ./arkade get --format markdown
  • I have updated the list of apps in README.md if (required) with ./arkade install --help

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have tested this on arm, or have added code to prevent deployment

@derek derek bot added the new-contributor label Jul 9, 2023
@alexellis
Copy link
Owner

Thanks for the PR. @Jasstkn do you have a moment to review?

@mkimberley mkimberley closed this Jul 31, 2023
@Jasstkn
Copy link
Contributor

Jasstkn commented Aug 2, 2023

@mkimberley hey! why did you close the PR?

@mkimberley
Copy link
Contributor Author

Hey! I'm going to re-submit this PR with a clean rebase from master due to conflicts with my original PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants