Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create draw package with fill rectangle function #87

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vlamai
Copy link

@vlamai vlamai commented Feb 12, 2021

Not sure that done all things right.
#87 commit to this issue
TODO:

  • add Border Rectangle without fill

@vlamai vlamai closed this Feb 13, 2021
@vlamai vlamai reopened this Feb 13, 2021
Copy link

@Nv7-GitHub Nv7-GitHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having a draw package would be nice! I could also add in filled circle support, and unfilled rectangle support!

}
}

func FillRectangle(img image.Image, r Rectangle) *image.RGBA {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just use FillRectangle(img image.Image, r image.Rect, color color.Color)

### Rectangle
result := draw.FillRectangle(img, NewRectangle(0, 0, 150, 250, color.White))

![example](assets/img/draw_fill_rect.jpg)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think something like rectfilled.jpg would fit in better with the rest of the image names

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants