Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix bun version of base image #1342

Merged
merged 1 commit into from
May 31, 2024
Merged

fix: Fix bun version of base image #1342

merged 1 commit into from
May 31, 2024

Conversation

MikuroXina
Copy link
Collaborator

@MikuroXina MikuroXina commented May 31, 2024

Type of Change:

Dockerfile の修正

Dealing with Problems (問題への対処)

Bun が semver へ厳密に従っておらずロックファイルの生成結果が整合しなくなることがあった. ベースイメージのバージョンがメジャーバージョンのみだったが, この問題への対処としてバージョン指定をパッチまで固定した.

@github-actions github-actions bot added the T-@oreorebot2/common Type: OreOreBot2 Common (packages/common) label May 31, 2024
Copy link
Contributor

Hadolint: success


@MikuroXina MikuroXina enabled auto-merge (squash) May 31, 2024 13:26
Copy link

Deploying oreorebot2 with  Cloudflare Pages  Cloudflare Pages

Latest commit: f5d6a98
Status: ✅  Deploy successful!
Preview URL: https://a0bb68f2.oreorebot2.pages.dev
Branch Preview URL: https://fix-bun-base.oreorebot2.pages.dev

View logs

Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.96%. Comparing base (89e8402) to head (f5d6a98).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1342   +/-   ##
=======================================
  Coverage   58.96%   58.96%           
=======================================
  Files         112      112           
  Lines        7323     7323           
  Branches      530      530           
=======================================
  Hits         4318     4318           
  Misses       2476     2476           
  Partials      529      529           
Flag Coverage Δ
unittests 58.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MikuroXina MikuroXina disabled auto-merge May 31, 2024 13:28
@MikuroXina MikuroXina merged commit d4e1a37 into main May 31, 2024
13 checks passed
@MikuroXina MikuroXina deleted the fix-bun-base branch May 31, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-@oreorebot2/common Type: OreOreBot2 Common (packages/common)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant