11211 - Allow use of graph slugs for ES reindex by type #11212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobtylerwalls
requested changes
Jul 19, 2024
arches/app/utils/index_database.py
Outdated
| @@ -327,30 +327,41 @@ def index_resources_by_type( | |||
|
|
|||
| for resource_type in resource_types: | |||
| start = datetime.now() | |||
| try: | |||
| uuid.UUID(str(resource_type)) | |||
| graph = models.GraphModel.objects.get(graphid=str(resource_type)) | |||
There was a problem hiding this comment.
This part will have to change because slugs are no longer unique in v8 -- they are shared across graph versions.
There was a problem hiding this comment.
I don't have a functioning v8 setup here so I'll just put this PR on hold for now until I have the time to get one up and running to sort this out.
arches/app/utils/index_database.py
Outdated
Comment on lines
334
to
341
| try: | ||
| graph = models.GraphModel.objects.get(slug=str(resource_type)) | ||
| except: | ||
| logger.warning( | ||
| "Unable to resolve resource type %s. Please confirm it is a valid graph ID or slug." | ||
| % resource_type | ||
| ) | ||
| continue |
There was a problem hiding this comment.
Is there a reason to have the log & continue only under one failure path? A UUID not in the db will still hard-crash.
bferguso
force-pushed
the
brf/11211_allow_slug_for_es_reindex
branch
from
ded33b2
to
bb49837
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description of Change
Adds the ability to also use the graph slug to define which resources to reindex
Issues Solved
Closes #11211
Checklist
Accessibility Checklist
Developer Guide
Ticket Background
Further comments
This allows the use of both graph UUID and graph slug to define the resource types to be reindexed.