Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate if user has no etl module permissions #11506

Merged
merged 7 commits into from
Sep 28, 2024

Conversation

chiatt
Copy link
Member

@chiatt chiatt commented Sep 27, 2024

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of Change

Indicates to user that they have no permissions to any bulk modules if they do not find any etl modules on the Bulk Data Manager page. This is because permissions were not enforced in 7.5, however, that issue is fixed in 7.6, so users accustomed to seeing modules may now find that that they can't see any in 7.6. Additionally, this PR adds a management command to allow an admin to grant or revoke permissions to etl modules in bulk.

Issues Solved

Closes #11450

Checklist

  • I targeted one of these branches:
    • dev/7.6.x (under development): features, bugfixes not covered below
    • dev/7.5.x (main support): regressions, crashing bugs, security issues, major bugs in new features
    • dev/6.2.x (extended support): major security issues, data loss issues
  • I added a changelog in arches/releases
  • I submitted a PR to arches-docs (if appropriate)
  • Unit tests pass locally with my changes
  • I added tests that prove my fix is effective or that my feature works
  • My test fails on the target branch

@chiatt chiatt requested review from aarongundel and apeters and removed request for apeters September 27, 2024 19:41
Copy link
Contributor

@aarongundel aarongundel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just a couple minor items here

tests/commands/test_permissions.py Outdated Show resolved Hide resolved
arches/management/commands/permissions.py Show resolved Hide resolved
@chiatt chiatt force-pushed the cnh/11450_etl_module_permissions branch from cb6ecb2 to ca50bb8 Compare September 28, 2024 17:38
Copy link
Contributor

@aarongundel aarongundel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aarongundel aarongundel merged commit de7d083 into dev/7.6.x Sep 28, 2024
7 checks passed
@aarongundel aarongundel deleted the cnh/11450_etl_module_permissions branch September 28, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants