Adding sia1 as servicetype
#583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That's so there is a symmetry to sia2. When further version 2-standards appear, I'd suggest we continue that pattern: The official IVOA short name (without numbers in version 1) remains, but a preferred alias with a 1 is added in pyVO. Note that access_modes and friends do not follow this logic; for SIA1, they still do the regular thing and use the IVOA short name. Would it make sense to convince the IVOA to add the 1 to their short names? Well, it would have all these years ago. Now... I think it would just increase the confusion.
|
This has been approved as part of #449, so once CI is all green, I'll go ahead and merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls out the backportable portion of adding of sia1 as servicetype from #449