Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smoothing functions do not use **kwargs for the astropy smoothing work #1147

Open
teuben opened this issue Jun 22, 2024 · 1 comment
Open

Comments

@teuben
Copy link
Contributor

teuben commented Jun 22, 2024

I'd like to use specutils.manipulation.gaussian_smooth, which calls astropy's smoothing functions, but specutils has a fixed API, does not pass on any possible **kwargs. Is this by design?

My reason is I'd like to get the boundary='expand' behavior on the edge, instead of the default boundary='fill'.

This particular case I was able to hack myself, but perhaps there are unintended consequences by opening this API up.

I can otherwise submit a PR.

@teuben
Copy link
Contributor Author

teuben commented Jun 25, 2024

In the upstream code (dysh) where we encountered this problem, we have switched to calls astropy's functions with boundary='expand' and so this issue has gone away for us. Yet, one could argue this is a problem here, unless there was a (design) reason not to pass anything ikn **kwargs.

@teuben teuben closed this as completed Jun 25, 2024
@teuben teuben reopened this Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant