Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Tabs to the design system #1116

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KhudaDad414
Copy link
Member

Description

  • Adds Tabs to the design system

Copy link

changeset-bot bot commented Jun 11, 2024

⚠️ No Changeset found

Latest commit: 5f17030

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Jun 11, 2024

Deploy Preview for studio-next ready!

Name Link
🔨 Latest commit 5f17030
🔍 Latest deploy log https://app.netlify.com/sites/studio-next/deploys/66686fad06e7660008dff7ce
😎 Deploy Preview https://deploy-preview-1116--studio-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 11, 2024

Deploy Preview for asyncapi-studio-design-system ready!

Name Link
🔨 Latest commit 5f17030
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-studio-design-system/deploys/66686fad1b45340008068900
😎 Deploy Preview https://deploy-preview-1116--asyncapi-studio-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 11, 2024

Deploy Preview for modest-rosalind-098b67 ready!

Name Link
🔨 Latest commit 5f17030
🔍 Latest deploy log https://app.netlify.com/sites/modest-rosalind-098b67/deploys/66686fad25ea2f00082ac950
😎 Deploy Preview https://deploy-preview-1116--modest-rosalind-098b67.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

sonarcloud bot commented Jun 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@princerajpoot20 princerajpoot20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KhudaDad414
Copy link
Member Author

/rtm

@KhudaDad414
Copy link
Member Author

@Amzani can I have a review here? 🙇

Copy link
Collaborator

@Amzani Amzani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KhudaDad414
Copy link
Member Author

/rtm

@Amzani
Copy link
Collaborator

Amzani commented Sep 11, 2024

@KhudaDad414 could you fix the conflict ?
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Ready
Development

Successfully merging this pull request may close these issues.

4 participants