-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add School Service #1
base: master
Are you sure you want to change the base?
Conversation
</configSections> | ||
<startup> | ||
<supportedRuntime version="v4.0" sku=".NETFramework,Version=v4.7" /> | ||
<supportedRuntime version="v4.0" sku=".NETFramework,Version=v4.6.1"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why framework downgrade?
protected override void OnModelCreating(DbModelBuilder modelBuilder) | ||
{ | ||
//Database.SetInitializer<KhorshidContext>(null); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete these comments if those codes are not useful anymore
foreach (var item in collection) | ||
{ | ||
if (item.Adreess.Contains(term)) | ||
goto findline; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid using goto
@@ -8,7 +8,7 @@ | |||
<OutputType>WinExe</OutputType> | |||
<RootNamespace>Khorshid</RootNamespace> | |||
<AssemblyName>Khorshid</AssemblyName> | |||
<TargetFrameworkVersion>v4.7</TargetFrameworkVersion> | |||
<TargetFrameworkVersion>v4.6.1</TargetFrameworkVersion> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still, why framework downgrade?
@@ -150,10 +152,15 @@ | |||
<Compile Include="Migrations\201808281316344_WorkPageSecondMigration.Designer.cs"> | |||
<DependentUpon>201808281316344_WorkPageSecondMigration.cs</DependentUpon> | |||
</Compile> | |||
<Compile Include="Migrations\201811021018262_Give_it_a_name.cs" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Choose better names for migrations
WindowStartupLocation="CenterScreen" | ||
WindowState="Maximized" | ||
mc:Ignorable="d"> | ||
<Window x:Class="Khorshid.MainWindow" xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation" xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml" xmlns:d="http://schemas.microsoft.com/expression/blend/2008" xmlns:fa="http://schemas.fontawesome.io/icons/" xmlns:local="clr-namespace:Khorshid" xmlns:mk="clr-namespace:Khorshid.MarkupExtensions" xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006" Title="آژانس بانوان خورشید" Width="1200" Height="600" FlowDirection="RightToLeft" FontFamily="{StaticResource Fonts.IRANSans}" Loaded="Window_Loaded" WindowStartupLocation="CenterScreen" WindowState="Maximized" mc:Ignorable="d"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid writing all the properties in a single line
|
||
|
||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove redundant spaces between methods
PersianCalendar p = new PersianCalendar(); | ||
|
||
|
||
var m = "فروردین اردیبهشت خرداد تیر مرداد شهریور مهر آبان آذر دی بهمن اسفند".Split(' '); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
choose better names for variables
Margin="10 0 0 0" | ||
Description="مشاهده و مدیریت سرویس های مدرسه"/> | ||
|
||
<c:SectionCard CardImage="{StaticResource Images.Drawing.Undraw.Map}" Title="مکان ها" Click="Areas_SectionCard_Click" Description="مشاهده و مدیریت قیمت های نواحی تحت پوشش آژانس" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, there is no benefit from writing all properties inline
CRUD for school service