Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

balena-unique-key: avoid all digits short UUIDs #3343

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

alexgg
Copy link
Contributor

@alexgg alexgg commented Jan 29, 2024

All digit short UUIDs are not resolved and instead treated as IP addresses. Iterate the UUID generation to avoid them starting with 7 digits.

Change-type: patch


Contributor checklist

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

All digit short UUIDs are not resolved and instead treated as IP
addresses. Iterate the UUID generation to avoid them starting with 7
digits.

Change-type: patch
Signed-off-by: Alex Gonzalez <[email protected]>
@alexgg alexgg marked this pull request as draft January 29, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant