Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adjustments for COS integration for reactive mode #390

Merged
merged 66 commits into from
Oct 16, 2024

Conversation

cbartz
Copy link
Collaborator

@cbartz cbartz commented Oct 14, 2024

Applicable spec: ISD-116

Overview

Also adapted the dashboard to show active runners:

Screenshot from 2024-10-11 23-50-23

Rationale

Juju Events Changes

Module Changes

Library Changes

Checklist

  • The charm style guide was applied.
  • The contributing guide was applied.
  • The changes are compliant with ISD054 - Managing Charm Complexity
  • The documentation is generated using src-docs.
  • The documentation for charmhub is updated.
  • The PR is tagged with appropriate label (urgent, trivial, complex).
  • The changelog is updated with changes that affects the users of the charm.
  • The changes do not introduce any regression in code or tests related to LXD runner mode.

src/shared_fs.py Show resolved Hide resolved
src/shared_fs.py Show resolved Hide resolved
tests/integration/test_charm_runner.py Show resolved Hide resolved
tests/integration/test_charm_runner.py Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
src/shared_fs.py Show resolved Hide resolved
Copy link
Contributor

Test coverage for c8477bd

Name                         Stmts   Miss Branch BrPart  Cover   Missing
------------------------------------------------------------------------
src/charm.py                   629    165    140     27    70%   247-249, 315-334, 352-354, 355->359, 385-389, 463-465, 474, 481-483, 504-509, 526-532, 553, 565-571, 586-587, 606-607, 616, 621, 651-652, 654->663, 658->663, 668-674, 708, 712-717, 768-773, 782->785, 808-820, 824-825, 853-880, 893-898, 917-927, 942-944, 991-992, 994-995, 997-998, 1077->1079, 1144-1145, 1183-1185, 1193-1199, 1277-1310, 1324-1329, 1344-1381, 1389-1390, 1412
src/charm_state.py             456     17     82      3    95%   276-288, 513-517, 639-640, 695-696, 1131->1134, 1138-1139, 1186
src/errors.py                   25      0      0      0   100%
src/event_timer.py              52      6      0      0    88%   105-106, 143-144, 160-161
src/firewall.py                 51     18     10      0    67%   42-43, 66-69, 111-185
src/github_client.py            23      2      4      0    93%   71-72
src/logrotate.py                43      0      2      0   100%
src/lxd_type.py                 35      0      0      0   100%
src/runner_manager_type.py      39      0      0      0   100%
src/runner_type.py              38      0      0      0   100%
src/shared_fs.py                98     17     10      1    83%   60-61, 132-133, 162-163, 171-172, 178-179, 210, 213-214, 226-227, 270-271
src/utilities.py                32      4      6      2    79%   66-69, 111
------------------------------------------------------------------------
TOTAL                         1521    229    254     33    83%

Static code analysis report

Run started:2024-10-16 08:01:36.732118

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 5046
  Total lines skipped (#nosec): 2
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 6

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@cbartz cbartz changed the title WIP - feat: Adjustments for COS integration for reactive mode feat: Adjustments for COS integration for reactive mode Oct 16, 2024
@cbartz cbartz marked this pull request as ready for review October 16, 2024 12:18
@cbartz cbartz requested a review from a team as a code owner October 16, 2024 12:18
Copy link
Contributor

@Thanhphan1147 Thanhphan1147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I only have 1 small comment.

@cbartz cbartz merged commit 5a31f10 into main Oct 16, 2024
92 of 99 checks passed
@cbartz cbartz deleted the feat/reactive-cos-ISD-1537 branch October 16, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants