Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record "recover-check" change and task logs when health check is failing #119

Closed
wants to merge 1 commit into from

Conversation

benhoyt
Copy link
Contributor

@benhoyt benhoyt commented May 9, 2022

Also record a task for every failure until the threshold, and close
the change (set it to Done) when the health check goes successful
again. The error message and any details is included in the task log.

This is similar to the "recover-service" change in #117,
but for health checks.

Fixes #103.

Also record a task for every failure until the threshold, and close
the change (set it to Done) when the health check goes successful
again. The error message and any details is included in the task log.
benhoyt added a commit to benhoyt/pebble that referenced this pull request May 9, 2022
@benhoyt
Copy link
Contributor Author

benhoyt commented May 17, 2022

Per discussion with @hpidcock (who had discussed with @niemeyer at the product sprint), we're leaning towards reserving changes and tasks only for user-initiated actions, and we're likely to add an "events" system and use events for this instead. Moving back to draft.

@benhoyt benhoyt marked this pull request as draft May 17, 2022 03:21
@benhoyt
Copy link
Contributor Author

benhoyt commented Jun 20, 2022

Per above comment, we're likely to use events for this instead. Closing for now (can always reopen later if necessary).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a way to detect and introspect check failures
1 participant