boot: provide a helper for obtaining boot chains for resealing #14625
+200
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedronis
reviewed
Oct 16, 2024
boot/seal.go
Outdated
| // BootChains constructs the boot chains which may be observed when booting the | ||
| // device such that they can be used as an input for resealing of encryption | ||
| // keys. | ||
| func BootChains(modeenv *Modeenv) (*ResealKeyForBootChainsParams, error) { |
There was a problem hiding this comment.
I thought the idea we discussed was to have WithBootChains ? did you go this way because is a bit easier to explain? do we have other use cases for WithModeenv?
There was a problem hiding this comment.
Fair point, perhaps there is no need to provide a helper for touching modeenv. I've pushed a patch.
bboozzoo
force-pushed
the
bboozzoo/export-from-boot
branch
from
2411eee
to
a763650
Compare
bboozzoo
changed the title
bboozzoo
force-pushed
the
bboozzoo/export-from-boot
branch
from
a763650
to
d202a77
Compare
bboozzoo
force-pushed
the
bboozzoo/export-from-boot
branch
from
d202a77
to
13bb3b3
Compare
valentindavid
approved these changes
Oct 16, 2024
bboozzoo
force-pushed
the
bboozzoo/export-from-boot
branch
from
13bb3b3
to
ba81c63
Compare
pedronis
force-pushed
the
fde-manager-features
branch
from
fcc5e2e
to
24018ee
Compare
Provide a dedicated helper for obtaining the boot chains relevant for resealing of disk encryption keys. Signed-off-by: Maciej Borzecki <[email protected]>
bboozzoo
force-pushed
the
bboozzoo/export-from-boot
branch
from
ba81c63
to
ac730af
Compare
|
Rebased on top of latest |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## fde-manager-features #14625 +/- ##
=======================================================
Coverage ? 78.87%
=======================================================
Files ? 1092
Lines ? 147425
Branches ? 0
=======================================================
Hits ? 116283
Misses ? 23891
Partials ? 7251
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Meulengracht
merged commit 0398511
into
canonical:fde-manager-features
44 of 57 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a dedicated helper for obtaining the boot chains relevant for
resealing of disk encryption keys.
Cherry picks from #14615