-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: run nested tests using ubuntu noble as host #14652
Draft
sergiocazzolato
wants to merge
8
commits into
canonical:master
Choose a base branch
from
sergiocazzolato:tests-run-nested-in-noble
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
tests: run nested tests using ubuntu noble as host #14652
sergiocazzolato
wants to merge
8
commits into
canonical:master
from
sergiocazzolato:tests-run-nested-in-noble
+190
−173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change change the image used as ubuntu host in nested tests. So far we used xenial for uc16, bionic for uc18, etc, which is unconvenient because we need to maintain several images and the code complexity also is higher. The system names went from ubuntu-xx.04-64 to ubuntu-xx-64, this is because we run ubuntu core and classic systems in the nested vms. Also it is convenient because otherwise we should change for example all the systems in the tests from ubuntu-2* to ubuntu-core-2* (or similar). Also the dependency packages installed in the neste host was reduced and the spread.yaml was simplified.
sergiocazzolato
added
the
Run nested
The PR also runs tests inluded in nested suite
label
Oct 18, 2024
github-actions
bot
added
the
Run Nested -auto-
Label automatically added in case nested tests need to be executed
label
Oct 18, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14652 +/- ##
==========================================
+ Coverage 78.89% 78.94% +0.05%
==========================================
Files 1083 1084 +1
Lines 146377 146643 +266
==========================================
+ Hits 115479 115773 +294
+ Misses 23695 23670 -25
+ Partials 7203 7200 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Run Nested -auto-
Label automatically added in case nested tests need to be executed
Run nested
The PR also runs tests inluded in nested suite
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the image used in the hosts for nested tests.
So far we used xenial for uc16, bionic for uc18, etc, which is not convenient because we need to maintain several images and the code complexity also is higher.
The system were renamed from ubuntu-XX.04-64 to ubuntu-XX-64. This is because we run ubuntu core and classic systems in the nested vms. Also it is convenient because otherwise, we should change for example all the systems in the tests from ubuntu-2* to ubuntu-core-2* (or similar).
Also the dependency packages installed in the nestet host was reduced and the spread.yaml was simplified.