Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: run nested tests using ubuntu noble as host #14652

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

sergiocazzolato
Copy link
Collaborator

This PR changes the image used in the hosts for nested tests.

So far we used xenial for uc16, bionic for uc18, etc, which is not convenient because we need to maintain several images and the code complexity also is higher.

The system were renamed from ubuntu-XX.04-64 to ubuntu-XX-64. This is because we run ubuntu core and classic systems in the nested vms. Also it is convenient because otherwise, we should change for example all the systems in the tests from ubuntu-2* to ubuntu-core-2* (or similar).

Also the dependency packages installed in the nestet host was reduced and the spread.yaml was simplified.

This change change the image used as ubuntu host in nested tests.

So far we used xenial for uc16, bionic for uc18, etc, which is
unconvenient because we need to maintain several images and the code
complexity also is higher.

The system names went from ubuntu-xx.04-64 to ubuntu-xx-64, this is
because we run ubuntu core and classic systems in the nested vms. Also
it is convenient because otherwise we should change for example all the
systems in the tests from ubuntu-2* to ubuntu-core-2* (or similar).

Also the dependency packages installed in the neste host was reduced and
the spread.yaml was simplified.
@sergiocazzolato sergiocazzolato added the Run nested The PR also runs tests inluded in nested suite label Oct 18, 2024
@github-actions github-actions bot added the Run Nested -auto- Label automatically added in case nested tests need to be executed label Oct 18, 2024
Copy link

codecov bot commented Oct 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.94%. Comparing base (2e47491) to head (1bb7274).
Report is 40 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #14652      +/-   ##
==========================================
+ Coverage   78.89%   78.94%   +0.05%     
==========================================
  Files        1083     1084       +1     
  Lines      146377   146643     +266     
==========================================
+ Hits       115479   115773     +294     
+ Misses      23695    23670      -25     
+ Partials     7203     7200       -3     
Flag Coverage Δ
unittests 78.94% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergiocazzolato sergiocazzolato marked this pull request as draft October 21, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run Nested -auto- Label automatically added in case nested tests need to be executed Run nested The PR also runs tests inluded in nested suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant