Add 2D Vortex example to notebooks #109
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is adding a new 2D vortex example to PyClaw notebooks. This is example 2.2 in the paper https://www.global-sci.org/v1/cicp/issue/FULLPDF/9/807/paper.pdf?code=5PGikBxEljgnVQwsaSy7Hg%3D%3D . It demonstrates how to solve the 2D Euler equations for compressible gas dynamics with periodic boundary conditions and perturbations to the mean flow. This notebook compares the performance between classical Clawpack and SharpClaw WENO solvers. The problem is initiated in the issue clawpack/pyclaw#714.
This changed the discrete L1-norm to continuous L1-norm for computing the error.
Compared to the previous one, this file adds a new example which compares the performance of Clawpack with SharpClaw on a vortex moving a small time.
|
Thanks, this sounds great! I will review it in the next few days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is adding a new 2D vortex example to PyClaw notebooks. This is example 2.2 in the paper https://www.global-sci.org/v1/cicp/issue/FULLPDF/9/807/paper.pdf?code=5PGikBxEljgnVQwsaSy7Hg%3D%3D . It demonstrates how to solve the 2D Euler equations for compressible gas dynamics with periodic boundary conditions and perturbations to the mean flow. This notebook compares the performance between classical Clawpack and SharpClaw WENO solvers. The problem is initiated in the issue clawpack/pyclaw#714.