Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/clojurescript #11

Closed
wants to merge 11 commits into from
Closed

feature/clojurescript #11

wants to merge 11 commits into from

Conversation

dazld
Copy link
Contributor

@dazld dazld commented Jan 26, 2020

Fixes #9

  • rename clj files to cljc
  • fix weird macro problem with resolve in cljs.
  • cljs cannot resolve vars at runtime, so the whole idea of passing symbols around dynamically isn't going to work
  • will need a bit of a rethink. how to pass a function inside quoted data?

in clj:

(def foo '[user/foo])
=> #'user/foo
(map resolve foo)
=> (#'user/foo)

but in cljs..

cljs.user=> (def foo '[cljs.user/foo])
#'cljs.user/foo
cljs.user=> (map resolve foo)
                 ⬆
WARNING: Can't take value of macro cljs.core/resolve at line 1
Cannot read property 'cljs$core$IFn$_invoke$arity$1' of undefined
	 (NO_SOURCE_FILE <embedded>:1077:140)
	 cljs.core.LazySeq.fn (NO_SOURCE_FILE <embedded>:1077:210)
	 cljs.core.LazySeq.sval (NO_SOURCE_FILE <embedded>:792:151)
	 cljs.core.LazySeq.cljs$core$ISeqable$_seq$arity$1 (NO_SOURCE_FILE <embedded>:798:255)
	 cljs.core.LazySeq.cljs$core$ISeq$_first$arity$1 (NO_SOURCE_FILE <embedded>:797:366)
	 Object.cljs.core._first (NO_SOURCE_FILE <embedded>:360:89)
	 Object.cljs.core.first (NO_SOURCE_FILE <embedded>:504:173)
	 lumo.pprint.data.LumoPrinter.fipp$visit$IVisitor$visit_seq$arity$2 (NO_SOURCE_FILE <embedded>:6551:104)
	 Object.fipp.visit.visit_seq (NO_SOURCE_FILE <embedded>:6301:103)
	 Object.fipp.visit.visit_STAR_ (NO_SOURCE_FILE <embedded>:6310:506)

@dazld dazld added enhancement New feature or request help wanted Extra attention is needed labels Jan 29, 2020
@@ -0,0 +1,3 @@

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: stray blank line before the shebang

@dazld dazld marked this pull request as draft March 27, 2021 16:05
@dazld
Copy link
Contributor Author

dazld commented Mar 28, 2021

closing - this is now quite out of date. will return in a new PR!

@dazld dazld closed this Mar 28, 2021
@dazld dazld deleted the feature/cljs branch March 28, 2021 10:47
@dazld dazld mentioned this pull request Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ClojureScript support
2 participants