Feature/fix dns setup for Proxmox #116
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* set interface dns changed to os console command
vladyslavpro01
changed the title
|
Hello, We are currently using opendev for patches: How to create an account and contribute to: Thank you, |
|
Hi - This relevant feature/fix does not seem to be added to OpenDev. |
|
Hello @Puben @vladyslavpro01, the first commit that changes the dns regex can be merged if a small patch is added to opendev. The second commit seems to be breaking the backwards compatibility -- why is the second commit needed? Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes DNS setup for Proxmox
related to #56
I've tested the
_set_interface_dnsit was not working, that's why I've changed it to a native os command call