cpuarch/vmsa: fix soundness issue with GuestVMExit #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Freax13
reviewed
Oct 10, 2024
p4zuu
force-pushed
the
vmexits_unsound
branch
from
fdca366
to
5c21bbf
Compare
Freax13
reviewed
Oct 10, 2024
p4zuu
force-pushed
the
vmexits_unsound
branch
from
5c21bbf
to
7c69f43
Compare
Freax13
approved these changes
Oct 10, 2024
|
Hey @p4zuu , can you please rebase this change to latest HEAD? Thanks! |
joergroedel
added
the
needs-rebase
Previously, it was possible for a guest to exit with an exit code undefined in the GuestVMExit enum, leading to undefined behavior. As suggested by @Freax13 in coconut-svsm#359, we can replace this by a tuple struct, allowing unknown values. Signed-off-by: Thomas Leroy <[email protected]>
p4zuu
force-pushed
the
vmexits_unsound
branch
from
7c69f43
to
e08fa76
Compare
@joergroedel done :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, it was possible for a guest to exit with an exit code undefined in the GuestVMExit enum, leading to undefined behavior.
As suggested by @Freax13 in #359, we can replace this by a tuple struct, allowing unknown values.