Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add try, except block #54

Merged
merged 2 commits into from
Sep 29, 2023
Merged

add try, except block #54

merged 2 commits into from
Sep 29, 2023

Conversation

dana-yaish
Copy link
Contributor

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #54 (993b038) into main (a481123) will decrease coverage by 0.02%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
- Coverage   91.80%   91.78%   -0.02%     
==========================================
  Files         101      101              
  Lines        8356     8361       +5     
  Branches     1269     1269              
==========================================
+ Hits         7671     7674       +3     
- Misses        683      685       +2     
  Partials        2        2              
Flag Coverage Δ
python3.10.5 88.55% <66.66%> (-0.03%) ⬇️
python3.8.13 88.65% <66.66%> (-0.03%) ⬇️
python3.9.12 88.98% <66.66%> (-0.03%) ⬇️
rust 90.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
shared/analytics_tracking/manager.py 81.81% <66.66%> (-6.42%) ⬇️

@dana-yaish dana-yaish changed the title add try, except block, temporary remove datetime from events add try, except block Sep 29, 2023
@dana-yaish dana-yaish merged commit acbebf5 into main Sep 29, 2023
9 of 13 checks passed
@dana-yaish dana-yaish deleted the dana/fix branch September 29, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants