fix: include fix for missing language normalization in sync_repos #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trent-codecov
approved these changes
Jul 28, 2023
matt-codecov
force-pushed
the
matt/hotfix-shared
branch
from
d147282
to
d394bab
Compare
Codecov Report
Changes have been made to critical files, which contain lines commonly executed in production. Learn more @@ Coverage Diff @@
## main #37 +/- ##
==========================================
+ Coverage 98.44% 98.63% +0.18%
==========================================
Files 354 355 +1
Lines 25583 25688 +105
==========================================
+ Hits 25186 25338 +152
+ Misses 397 350 -47
Flags with carried forward coverage won't be shown. Click here to find out more.
see 18 files with indirect coverage changes This change has been scanned for critical changes. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
codecov/shared#15 fixes an issue causing a lot of
sync_reposfailures. the PR was merged on main, but the hash used here is a hash that was rebased atop the currently-deployedsharedhash. so if we deploy worker with this, it will only include the fix fromsharedand not other changes.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.