[FEC-49] - shipping info model #664
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoniolodias
added
the
fe-chapter-rotation
🦋 Changeset detectedLatest commit: d7734a4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 46 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
antoniolodias
changed the title
|
currently blocked by #669 |
jaikumar-tj
reviewed
Sep 4, 2024
Comment on lines
91
to
93
| // taxedPrice: expect.objectContaining({ | ||
| // totalNet: expect.objectContaining({ centAmount, currencyCode }), | ||
| // }), |
There was a problem hiding this comment.
can this be uncommented? or was there some issue?
There was a problem hiding this comment.
This should be working now after adding missing models and adjusting tests in this PR: 4a33806
This will be fixed once the #669 PR is merged. |
antoniolodias
force-pushed
the
FEC-49_shipping-info-model
branch
from
cc25f6e
to
fdd4d3f
Compare
antoniolodias
force-pushed
the
FEC-49_shipping-info-model
branch
from
fdd4d3f
to
d7734a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR creates shipping info model needed for this migration PR which is based on batch 12 of the chapter epic where we are migrating tests to use public test-data package