chore(ci,test): modifying pr-check e2e to build extension from ref #1960
+76
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScrewTSW
force-pushed
the
1944-fix-pr-check-e2e-use-local-changes
branch
7 times, most recently
from
95e4a6a
to
3c7ded0
Compare
Signed-off-by: Tibor Dancs <[email protected]>
ScrewTSW
force-pushed
the
1944-fix-pr-check-e2e-use-local-changes
branch
from
80418c1
to
51b6486
Compare
benoitf
reviewed
Oct 21, 2024
.github/workflows/pr-check.yaml
Outdated
Comment on lines
145
to
147
| podman export $CONTAINER_ID > /tmp/local_ai_lab_extension.tar | ||
| mkdir -p tests/playwright/tests/playwright/output/ai-lab-tests-pd/plugins | ||
| tar -xf /tmp/local_ai_lab_extension.tar -C tests/playwright/tests/playwright/output/ai-lab-tests-pd/plugins/ |
There was a problem hiding this comment.
can you do export and pipe to untar it rather than using an intermediate file
docker export $CONTAINER_ID | tar -x -C tests/playwright/tests/playwright/output/ai-lab-tests-pd/plugins/
also need to cleanup the remove the container
…sion details page, possible error logging Signed-off-by: Tibor Dancs <[email protected]>
ScrewTSW
force-pushed
the
1944-fix-pr-check-e2e-use-local-changes
branch
from
51b6486
to
19b2c5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Screenshot / video of UI
N/A
What issues does this PR fix or reference?
#1944
How to test this PR?
N/A