-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix svelte 5 deprecation warning #9331
base: main
Are you sure you want to change the base?
Conversation
there is a typecheck failure then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems other change is required
Weirdly enough we need to remove the following lines
Note sure if they are important ? But removing them fix the svelte-check on my machine |
I haven't tried yet, but I'd expect removing that would break reactivity for actions, e.g. if you click start, the icon button on the left wouldn't change. |
It does, I've tried it, and it seems to work fine |
setting to draft as it's not passing pr checks |
Fixes containers#9313. Signed-off-by: Tim deBoer <[email protected]>
20663a5
to
d9ff198
Compare
Sorry for the delay. Rebased and included on:update removal, moving back to review. I wanted a chance to thoroughly test, and I could not break it. I concur with @axel7083, on:update is no longer required, svelte 5 ftw. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested running, starting, stopping, removing containers, the table is working on my side.
Also deleting images works, the table update properly
@jeffmaury please re-review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked with Pods and Containers, it all updated fine to me 👍
What does this PR do?
Replaces code to remove deprecation warning.
Screenshot / video of UI
N/A
What issues does this PR fix or reference?
Fixes #9313.
How to test this PR?
PR checks.