Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update Updater button names to fit in message box - 1.13.x #9499

Open
wants to merge 3 commits into
base: 1.13.x
Choose a base branch
from
+5 −5
Open

fix: update Updater button names to fit in message box - 1.13.x #9499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9745e97
fix: update Updater button names to fit in message box
SoniaSandler Oct 21, 2024
27345bb
chore: fix linter
SoniaSandler Oct 21, 2024
dad3be6
chore: update update-install e2e test
SoniaSandler Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/main/src/plugin/updater.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,7 +419,7 @@ describe('expect update command to depends on context', async () => {

expect(messageBoxMock.showMessageBox).toHaveBeenCalledWith({
cancelId: 2,
buttons: ['Update now', 'View release notes', 'Remind me later', 'Do not show again'],
buttons: ['Update now', `What's new`, 'Remind me later', `Don't show again`],
message:
'A new version v@debug-next of Podman Desktop is available. Do you want to update your current version v@debug?',
title: 'Update Available now',
Expand All @@ -435,7 +435,7 @@ describe('expect update command to depends on context', async () => {

expect(messageBoxMock.showMessageBox).toHaveBeenCalledWith({
cancelId: 2,
buttons: ['Update now', 'View release notes', 'Cancel'],
buttons: ['Update now', `What's new`, 'Cancel'],
message:
'A new version v@debug-next of Podman Desktop is available. Do you want to update your current version v@debug?',
title: 'Update Available now',
Expand Down
4 changes: 2 additions & 2 deletions packages/main/src/plugin/updater.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,9 +214,9 @@ export class Updater {

let buttons: string[];
if (context === 'startup') {
buttons = ['Update now', 'View release notes', 'Remind me later', 'Do not show again'];
buttons = ['Update now', `What's new`, 'Remind me later', `Don't show again`];
} else {
buttons = ['Update now', 'View release notes', 'Cancel'];
buttons = ['Update now', `What's new`, 'Cancel'];
}

const result = await this.messageBox.showMessageBox({
Expand Down
2 changes: 1 addition & 1 deletion tests/playwright/src/specs/installation/update-install.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ test.describe.serial('Podman Desktop Update Update installation offering @update
await playExpect(updateAvailableDialog).toBeVisible();
const updateNowButton = updateAvailableDialog.getByRole('button', { name: 'Update Now' });
await playExpect(updateNowButton).toBeVisible();
const doNotshowButton = updateAvailableDialog.getByRole('button', { name: 'Do not show again' });
const doNotshowButton = updateAvailableDialog.getByRole('button', { name: `Don't show again` });
await playExpect(doNotshowButton).toBeVisible();
const cancelButton = updateAvailableDialog.getByRole('button', { name: 'Cancel' });
await playExpect(cancelButton).toBeVisible();
Expand Down
Loading