Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(yaml): test parsing of single quoted scalars #5356

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Jul 8, 2024

part of #3713

This PR add test cases that exercises the parsing of single quoted strings.

This improves the coverage of yaml/_loader.ts from 82.51% to 84.76%.

@github-actions github-actions bot added the yaml label Jul 8, 2024
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.33%. Comparing base (0d668fa) to head (a940b3d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5356      +/-   ##
==========================================
+ Coverage   96.24%   96.33%   +0.08%     
==========================================
  Files         458      458              
  Lines       37849    37849              
  Branches     5608     5619      +11     
==========================================
+ Hits        36427    36460      +33     
+ Misses       1381     1348      -33     
  Partials       41       41              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@kt3k kt3k merged commit be9eb72 into denoland:main Jul 9, 2024
13 checks passed
@kt3k kt3k deleted the test-yaml-parse-single-quote-scalar branch July 9, 2024 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants