Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double to float conversion warnings in virtual gamepad logic #7475

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

StephenCWills
Copy link
Member

Fixes these warnings, highlighted by GitHub's nifty beta feature.

image

@StephenCWills
Copy link
Member Author

Weird quirk about g++ and cmath.
https://stackoverflow.com/a/43183942

g++ 5.x though 7, sqrtf and floorf are not within the std namespace under -std=c++11, -std=c++14 or -std=c++1z. They are simply in the global namespace, when cmath is included.

I assume we're using a later version of the compiler, but the info seems to be still relevant.

@AJenbo AJenbo merged commit 3caa80f into diasurgical:master Oct 11, 2024
23 checks passed
@StephenCWills StephenCWills deleted the float-conversion-warnings branch October 11, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants