Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bpfkorea/agora and Geod24/localrest #394

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Geod24
Copy link
Member

@Geod24 Geod24 commented Jul 3, 2019

The former is our company's main project and uses a lot of C++ interop on POSIX.
The second uses threads, message passing and std.concurrency.

Agora actually caught regression 20022, so we'll have to wait for stable to have dlang/dmd#10127 and for it to be merged into master before merging this.

@dlang-bot
Copy link
Collaborator

Thanks for your pull request, @Geod24!

@thewilsonator
Copy link
Contributor

Oh, I don't have write access here, you'll have to wait fo someone else.

@Geod24
Copy link
Member Author

Geod24 commented Jul 3, 2019

Oh it somehow tries to use master instead of the default branch setup in the repo :/

@wilzbach
Copy link
Member

wilzbach commented Jul 3, 2019

Oh it somehow tries to use master instead of the default branch setup in the repo :/

Yes of course. That's the main development branch. Just run merge_stable and you should be good to go.

@Geod24
Copy link
Member Author

Geod24 commented Jul 3, 2019

Yes of course. That's the main development branch.

I was talking about the repository being tested, e.g.:


Cloning https://github.com/bpfkorea/agora (tag: master) | 1s
-- | --
  | ~> git clone -b master --depth 1 https://github.com/bpfkorea/agora bpfkorea-agora
  | Cloning into 'bpfkorea-agora'...
  | warning: Could not find remote branch master to clone.
  | fatal: Remote branch master not found in upstream origin
  | 🚨 Error: The command exited with status 128

I'm going to check how it's done for Sociomantic projects, as they don't have a master branch either.

The former is our company's main project and uses a lot of C++ interop on POSIX.
The second uses threads, message passing and std.concurrency.
@Geod24
Copy link
Member Author

Geod24 commented Jul 5, 2019

Got it: as we don't have a tagged release yet, it tries to use master. So I just made it use v0.x.x which is our dev branch.

@Geod24
Copy link
Member Author

Geod24 commented Jul 5, 2019

I need libsodium and a recent C++ compiler... Any clue how to add this @wilzbach ?

@wilzbach
Copy link
Member

wilzbach commented Jul 5, 2019

I need libsodium and a recent C++ compiler... Any clue how to add this @wilzbach ?

It used to be that you could just add your dependencies to the ansible files (

), but since the agents are now created on the fly from an image (see e.g. #311), I'm not sure whether just adding it there is enough.
Re recent C++ compiler: the agents use Debian Jessie, so that might be a bit hard.

@Geod24
Copy link
Member Author

Geod24 commented Jul 6, 2019

Re recent C++ compiler: the agents use Debian Jessie, so that might be a bit hard.

Yeah I need 6.1 and Jessie uses 4.9. So I guess this is a dead end ? If so I'll just remove agora from the list for the time being.

@wilzbach
Copy link
Member

wilzbach commented Jul 8, 2019

Yeah you probably have to ping Martin Nowak for a newer Buildkite image.

@Geod24
Copy link
Member Author

Geod24 commented Jul 8, 2019

Blocked by #396

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants