Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bugzilla Issue 23131 - With -vasm all the X87 instructions are printed wrong #17010

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix bugzilla Issue 23131 - With -vasm all the X87 instructions are printed wrong #17010

wants to merge 1 commit into from

Conversation

WalterBright
Copy link
Member

it was skipping the "fn" prefix.

@WalterBright WalterBright added Easy Review Backend glue code, optimizer, code generation labels Oct 16, 2024
@dlang-bot
Copy link
Contributor

dlang-bot commented Oct 16, 2024 •
edited
Loading

Thanks for your pull request, @WalterBright!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

  • In preparation for migrating from Bugzilla to GitHub Issues, the issue reference syntax has changed. Please add the word "Bugzilla" to issue references. For example, Fix Bugzilla Issue 12345 or Fix Bugzilla 12345.(Reminder: the edit needs to be done in the Git commit message, not the GitHub pull request.)

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#17010"

thewilsonator
thewilsonator reviewed Oct 16, 2024
View reviewed changes
Copy link
Contributor

@thewilsonator thewilsonator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue number? test cases?

@WalterBright WalterBright force-pushed the format87 branch 3 times, most recently from f0c08d0 to 7311523 Compare October 16, 2024 07:51
@WalterBright WalterBright changed the title correct disassembly of x86 instructions Issue 23131 - With -vasm all the X87 instructions are printed wrong Oct 16, 2024
@WalterBright WalterBright changed the title Issue 23131 - With -vasm all the X87 instructions are printed wrong fix Issue 23131 - With -vasm all the X87 instructions are printed wrong Oct 16, 2024
@WalterBright WalterBright changed the title fix Issue 23131 - With -vasm all the X87 instructions are printed wrong fix bugzilla Issue 23131 - With -vasm all the X87 instructions are printed wrong Oct 16, 2024
dkorpel
dkorpel approved these changes Oct 16, 2024
View reviewed changes
compiler/src/dmd/backend/x86/disasm86.d
put('\t');
if (waitflag)
put(' ');
if (0 && waitflag)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a use for this dead branch?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Support for the older x87 instruction set.

thewilsonator
thewilsonator requested changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@thewilsonator thewilsonator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please retitle the commit message "fix bugzilla Issue 23131..."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thewilsonator thewilsonator thewilsonator requested changes

@dkorpel dkorpel dkorpel approved these changes

@RazvanN7 RazvanN7 RazvanN7 approved these changes

Assignees
No one assigned
Labels
Backend glue code, optimizer, code generation Easy Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@WalterBright @dlang-bot @thewilsonator @dkorpel @RazvanN7