pop_back function for vector on CppRuntime_Clang #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emmankoko
force-pushed
the
Mvecctor/pop_back
branch
2 times, most recently
from
5895ae5
to
b3828ba
Compare
Geod24
reviewed
Feb 19, 2024
source/stdcpp/vector.d
Outdated
Comment on lines
915
to
916
| pointer __begin_ = null; | ||
| pointer __end_ = null; |
There was a problem hiding this comment.
Suggested change
| pointer __begin_ = null; | |
| pointer __end_ = null; | |
| pointer __begin_; | |
| pointer __end_; |
null is the default for pointers in D.
There was a problem hiding this comment.
yess, true... let me make that alterations
|
I'm not familiar with ASAN annotation, anything I can read on ? |
Look at |
Emmankoko
force-pushed
the
Mvecctor/pop_back
branch
3 times, most recently
from
e338d6f
to
21a5353
Compare
Geod24
approved these changes
Jun 18, 2024
Geod24
force-pushed
the
Mvecctor/pop_back
branch
from
21a5353
to
bb6f683
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With functions like pop_back and push_back, there have been recent ASAN(address sanitization) annotations that have been added to check for some memory poisoning with the unsafe usage of unused capacity since reallocations can produce larger capacity than the number of elements in the container so there will be few unused memory that will not be safe to use. I looked through it, and It is whole poisoning runtime library not part of the STL.
I think now that we have pop_back working, there's a Todo comment left in pop_back function which I think will be good for us to integrate that as a future work.
can check it out here:
PATCH
Library