-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding cohost completion handler #11048
base: main
Are you sure you want to change the base?
Commits on Sep 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a53d3a6 - Browse repository at this point
Copy the full SHA a53d3a6View commit details
Commits on Sep 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 627c7e7 - Browse repository at this point
Copy the full SHA 627c7e7View commit details
Commits on Sep 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ecd74a4 - Browse repository at this point
Copy the full SHA ecd74a4View commit details
Commits on Sep 24, 2024
-
Adding OOPRazorCompletionFactsService and moving MarkupTransitionComp…
…letionItemProvider to common layer.
Configuration menu - View commit details
-
Copy full SHA for ba4b5ec - Browse repository at this point
Copy the full SHA ba4b5ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for d9220c8 - Browse repository at this point
Copy the full SHA d9220c8View commit details
Commits on Sep 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 018b57d - Browse repository at this point
Copy the full SHA 018b57dView commit details
Commits on Oct 2, 2024
-
Add OOP MEF exports for completion services from Workspaces layer nee…
…ded by RemoteCompletionService
Configuration menu - View commit details
-
Copy full SHA for 909c3aa - Browse repository at this point
Copy the full SHA 909c3aaView commit details
Commits on Oct 5, 2024
-
Hook up RazorComplelistListProvider in the RemoteCompletionService
Switch passed in and returned types from Roslyn to VS Platform LSP types since that's what all of the common completion code in the Workspaces layer uses. We will need to convert returned Roslyn completion items to VS platform LSP completion items.
Configuration menu - View commit details
-
Copy full SHA for f3a44db - Browse repository at this point
Copy the full SHA f3a44dbView commit details
Commits on Oct 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f120c08 - Browse repository at this point
Copy the full SHA f120c08View commit details -
Configuration menu - View commit details
-
Copy full SHA for 74fc3c6 - Browse repository at this point
Copy the full SHA 74fc3c6View commit details -
Common code for completion trigger characters and correct character s…
…et used in cohosting
Configuration menu - View commit details
-
Copy full SHA for 5cc1400 - Browse repository at this point
Copy the full SHA 5cc1400View commit details -
Configuration menu - View commit details
-
Copy full SHA for 198b404 - Browse repository at this point
Copy the full SHA 198b404View commit details -
Move IsValidTrigger method to CompletionTriggerCharacters class in th…
…e workspaces layer (to be used in cohosting later)
Configuration menu - View commit details
-
Copy full SHA for 6265966 - Browse repository at this point
Copy the full SHA 6265966View commit details -
Call HTML completion only if we are in HTML and pass a set of existin…
…g HTML completion item labels to RazorCompletionListProvider
Configuration menu - View commit details
-
Copy full SHA for cf7a94a - Browse repository at this point
Copy the full SHA cf7a94aView commit details -
Pass C# existing completion item labels to RazorCompletionListProvide…
…r and minor cleanup
Configuration menu - View commit details
-
Copy full SHA for f2f7e9c - Browse repository at this point
Copy the full SHA f2f7e9cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 311973b - Browse repository at this point
Copy the full SHA 311973bView commit details -
Configuration menu - View commit details
-
Copy full SHA for d17c36d - Browse repository at this point
Copy the full SHA d17c36dView commit details
Commits on Oct 12, 2024
-
Move delegated completion helper RewriteContext method into Workspace…
… layer and use it in cohost completion request
Configuration menu - View commit details
-
Copy full SHA for bcf2080 - Browse repository at this point
Copy the full SHA bcf2080View commit details
Commits on Oct 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 598686b - Browse repository at this point
Copy the full SHA 598686bView commit details
Commits on Oct 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 62ced4e - Browse repository at this point
Copy the full SHA 62ced4eView commit details -
Consuming delegated completion response re-writers in C#
Also simplifying parameters passed to the response re-writers to only what's needed.
Configuration menu - View commit details
-
Copy full SHA for 3070b26 - Browse repository at this point
Copy the full SHA 3070b26View commit details -
Switch to Roslyn CompletionParams as request input so converters are …
…hooked up and we are getting VSInternalCompletionContext in CompletionParams
Configuration menu - View commit details
-
Copy full SHA for 15be771 - Browse repository at this point
Copy the full SHA 15be771View commit details
Commits on Oct 15, 2024
-
Splitting delegated response rewriters into C# and HTML and simplifyi…
…ng them They all already checked (or should've checked) for language and were operating on either C# or HTML, never on both. HTML re-writer will get called from the client and can be much simpler. In cohosting it doesn't make sense to have them all in one list since C# will get called in OOP and HTML on the client (in VS).
Configuration menu - View commit details
-
Copy full SHA for d25ab7e - Browse repository at this point
Copy the full SHA d25ab7eView commit details -
Moving ShouldIncludeSnippets helper into the common layer and hooking…
… it up in cohosting
Configuration menu - View commit details
-
Copy full SHA for 605b8b0 - Browse repository at this point
Copy the full SHA 605b8b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 252d4ac - Browse repository at this point
Copy the full SHA 252d4acView commit details
Commits on Oct 17, 2024
-
First part of completion options clean-up
Renamed some fields and variables dealing with "add snippets" options and added comments. We currently have two options that mean "add snippets" - one for the delegated completion, and one for Razor completion. The values of those don't correlate. The Razor one is always true in LSP and Cohost, always false for legacy editor. The delegation one actually depends on the position.
Configuration menu - View commit details
-
Copy full SHA for 8f94a13 - Browse repository at this point
Copy the full SHA 8f94a13View commit details -
Configuration menu - View commit details
-
Copy full SHA for f5c7633 - Browse repository at this point
Copy the full SHA f5c7633View commit details
Commits on Oct 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 95f9410 - Browse repository at this point
Copy the full SHA 95f9410View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9505241 - Browse repository at this point
Copy the full SHA 9505241View commit details
Commits on Oct 19, 2024
-
Adding directive and directive attribute completion providers and tests
Also adding a snippet completion provider test and markup transition test
Configuration menu - View commit details
-
Copy full SHA for a0514fa - Browse repository at this point
Copy the full SHA a0514faView commit details -
Configuration menu - View commit details
-
Copy full SHA for f646b03 - Browse repository at this point
Copy the full SHA f646b03View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d29f9c - Browse repository at this point
Copy the full SHA 6d29f9cView commit details -
Moved most of the tests for moved code from LanguageServer to Workspa…
…ces test projects The tests were left behind (some in this PR, some in prior PRs) when the code was moved to Workspaces layer. This commit addresses most of them other than in Delegation subworkspace
Configuration menu - View commit details
-
Copy full SHA for 3312cea - Browse repository at this point
Copy the full SHA 3312ceaView commit details -
Fixing delegated response re-writer tests.
We had inconsistent handling of null completion item labels between our response re-writers. Some handled null labels, others would through. Since label shouldn't be null (non-nullable), I adjusted the tests not to use null labels. Also the tests previously passed because they created DelegatedCompletionListProvider with only a selected DelegatedResponseRewriter. Now the DelegatedCompletionHelper will apply all response re-writers for the correct language (either C# or HTML), which is what the product actually does, so I feel that's fine. It exposed these test failures due to inconsistent null label handling
Configuration menu - View commit details
-
Copy full SHA for 81a1124 - Browse repository at this point
Copy the full SHA 81a1124View commit details -
Configuration menu - View commit details
-
Copy full SHA for 82d275c - Browse repository at this point
Copy the full SHA 82d275cView commit details
Commits on Oct 20, 2024
-
Add required cancellation token argument to GetGeneratedDocumentAsync…
… in RemoteCompletionService
Configuration menu - View commit details
-
Copy full SHA for bbea1db - Browse repository at this point
Copy the full SHA bbea1dbView commit details -
Simplifying trigger character data
Switching AllTriggerCharacters to string[] since we only use it for registration/capability data, which needs string[]. and we never do look ups via Contains. Also removing rendundant property and calculations in CompletionListProvider
Configuration menu - View commit details
-
Copy full SHA for c5722bc - Browse repository at this point
Copy the full SHA c5722bcView commit details
Commits on Oct 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ec28f9f - Browse repository at this point
Copy the full SHA ec28f9fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7129038 - Browse repository at this point
Copy the full SHA 7129038View commit details -
Configuration menu - View commit details
-
Copy full SHA for 538e3be - Browse repository at this point
Copy the full SHA 538e3beView commit details -
Configuration menu - View commit details
-
Copy full SHA for c744e13 - Browse repository at this point
Copy the full SHA c744e13View commit details