Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added: Faker.Cannabis #269

Merged
merged 6 commits into from
Aug 4, 2019
Merged

Added: Faker.Cannabis #269

merged 6 commits into from
Aug 4, 2019

Conversation

nurugger07
Copy link
Contributor

This PR includes modules for cannabis related data. Around the world, this is a rapidly growing industry and it would be good to have these modules included in faker.

I've added:

  • USAGE.md docs if applicable
  • CHANGELOG.md

@nurugger07
Copy link
Contributor Author

@igas just wanted to follow up on this PR. Have you had a chance to look at it & discuss with the other maintainers? The ruby faker project has a similar implementation for cannabis.

https://github.com/stympy/faker/blob/master/lib/faker/default/cannabis.rb

Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm currently living in Vancouver/Canada and weed is legal here. Cannabis market is skyrocketing with some startups and cannabis is a commodity.

Even though this faker generator may not be heavily used, it'd be cool to have it. I'd probably include a namespace for it and add other faker "not too popular" generators in this namespace. Perhaps Faker.PopCulture.Cannabis?

lib/faker/cannabis.ex Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@nurugger07
Copy link
Contributor Author

@vbrazo regarding the namespace comment: should other fakers like beer be under the Faker.PopCulture namespace?

@anthonator
Copy link
Collaborator

I don't know if I agree with adding a PopCulture namespace. Seems unnecessary to me.

@nurugger07
Copy link
Contributor Author

I don't know if I agree with adding a PopCulture namespace. Seems unnecessary to me.

I agree with @anthonator :)

@nurugger07
Copy link
Contributor Author

Just checking on this

@igas
Copy link
Member

igas commented Aug 4, 2019

Hi all,

this looks good to me. Namespace-wise we'll need one see #207 & #208. Having said that, coming with good categories will be hard. I think for now I would continue this path to not make it harder to contribute, and then bump to 1.0 with namespaces. Most likely with deprecations before that.

@vbrazo vbrazo merged commit d9b77d0 into elixirs:master Aug 4, 2019
@vbrazo vbrazo changed the title Cannabis fakes Added: Faker.Cannabis Aug 5, 2019
@vbrazo vbrazo changed the title Added: Faker.Cannabis Added: Faker.Cannabis Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants