Fix remaining time after change page visability #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kinzaz
force-pushed
the
fix-remainTime-after-change-page-visability
branch
from
da6a0bc
to
7d8cc05
Compare
kinzaz
force-pushed
the
fix-remainTime-after-change-page-visability
branch
from
7d8cc05
to
5c14157
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
There is no recalculation remaining time after visability change, remaining time is constantly being recreated and elapsedTime doesn't make sense
Closes https://github.com/emilkowalski/sonner/issues/
What has been done:
Remaining time is now ref and it keeps the value of remaining time.
Screenshots/Videos:
N/A