[auth] improve packaging and db path #3334
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prateekmedia
force-pushed
the
auth-linux-fixes
branch
from
00415cb
to
cdbcc93
Compare
13 tasks
|
I noticed package_name: enteauthIs it not supported or just missing? :) |
|
Should we generate a build for this, and get it tested on all variants with offline mode? |
prateekmedia
force-pushed
the
auth-linux-fixes
branch
from
37bfddb
to
d7946fb
Compare
prateekmedia
changed the title
prateekmedia
changed the title
ua741
reviewed
Oct 15, 2024
|
|
||
| sharedPrefs.setBool(migratedNamingChanges, true).ignore(); | ||
| } catch (e, st) { | ||
| logger.warning("Migrating Database failed!", e, st); |
There was a problem hiding this comment.
Should we rethrow the exception here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tests (Only changes windows and linux)