[mob][photos] Implement deep linking for public links #3386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashilkn
reviewed
Sep 23, 2024
|
|
||
| CollectionPage( | ||
| this.c, { | ||
| this.tagPrefix = "collection", | ||
| this.hasVerifiedLock = false, | ||
| this.isFromCollectPhotos = false, | ||
| Key? key, | ||
| this.isFromPublicShareLink = false, | ||
| this.sharedLinkFiles = const [], |
There was a problem hiding this comment.
I feel it's better to make this nullable and null be its default value. So that it can be easily identified if sharedLinkFiles was passed (non-null) or not (null).
If we use an empty list by default, it would be hard to know if the link has no files or if a sharedLinkFiles was never passed. In the future the need to know this might arise.
We can also add an assert that if isFromPublicShareLink == true, sharedLinkFiles cannot be null.
ashilkn
reviewed
Sep 23, 2024
## Description ## Tests
…ing loading dialog till the album is fetched
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Opening an Ente photos public link in the app if the app is installed in phone.