Merge pull request #70 from extism/fix/targets-props

fix: remove condition on .targets property group
extism · Feb 29, 2024 · 783b6bd · 783b6bd
2 parents 9bec701 + 5e9784d
commit 783b6bd
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 6 deletions.
diff --git a/README.md b/README.md
@@ -31,11 +31,6 @@ Update your `MyPlugin.csproj`/`MyPlugin.fsproj` as follows:
     <TargetFramework>net8.0</TargetFramework>
     <RuntimeIdentifier>wasi-wasm</RuntimeIdentifier>
     <OutputType>Exe</OutputType>
-    <PublishTrimmed>true</PublishTrimmed>
-
-    <!-- Make sure we create a standalone wasm file for our plugin -->
-    <WasmSingleFileBundle>true</WasmSingleFileBundle>
-    <WasmBuildNative>true</WasmBuildNative>
   </PropertyGroup>
 </Project>
 ```

diff --git a/src/Extism.Pdk/build/Extism.Pdk.targets b/src/Extism.Pdk/build/Extism.Pdk.targets
@@ -3,7 +3,7 @@
 		<TrimmerRootAssembly Include="Extism.Pdk" />
 	</ItemGroup>
 
-	<PropertyGroup Condition=" '$(Configuration)' == 'Release' ">
+	<PropertyGroup>
 		<PublishTrimmed>true</PublishTrimmed>
 		<WasmBuildNative>true</WasmBuildNative>
 		<WasmSingleFileBundle>true</WasmSingleFileBundle>