Allow browsers to specify fd preopens #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expose a new interface, `wasiOptions`, to accommodate platform-specific configuration for WASI. For now, this is limited to supporting fd preopens in browser environments (since none of Deno, Node, nor Bun support pre-allocating fds in this fashion.)
|
I've got a fix for the test failure in #65; a new version of Deno introduced a regression in the build (tracked as denoland/deno#23721.) |
|
@kevinbarabash If you have a moment, could you check this PR out and see if it meets your needs? |
|
@kevinbarabash, if you're unable to verify, then we'll likely merge this if it satisfy's @chrisdickinson's expectations. It's blocking our release though, so we'd like to know if you're interested in confirming. No problem if not! Let's give this a couple more days, and then proceed as we'd like. |
nilslice
reviewed
Jun 17, 2024
src/polyfills/browser-wasi.ts
Outdated
| ): Promise<InternalWasi> { | ||
| console.log('fileDescriptors = ', fileDescriptors); |
There was a problem hiding this comment.
@chrisdickinson - does this console.log need to be here, or just leftover from debugging?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A continuation of #59.
Fd preopens are specific to
@bjorn3/browser_wasi_shim. We expose an option to specify them insrc/interfaces.ts, but the Fd type is specified asany[]because we can't directly reference that package from Deno/Node TS builds.(This is a v2.0.0 release candidate feature.)