[Bugfix] Switch tar crate to make tar.gz decompression work

[kageiit]

Fixes #27

[kageiit]

happy to add tests. The fixtures currently come from some temp repo with no instructions. Im not sure what is a good way to generate a test fixture for the PAX 1.0 file format - https://www.gnu.org/software/tar/manual/html_node/PAX-1.html

[thoughtpolice]

I just ran into #27. Is there anything preventing this from being merged? This is a pretty important fix since it's somewhat impossible to tell ahead of time what tarfiles will work and what won't.

/cc @bigfootjon I suppose?

[bolinfest]

I suspect tests are the long pole here? /cc @zertosh

Also, the fixtures still point to a personal repo (which is something we needed to do when this repo was still private prior to launch so it didn't break the internal Meta CI), but ideally that would also be changed now, e.g.:

dotslash/tests/generate_fixtures.py

Line 28 in 76bbc25

GITHUB_REPO = "https://github.com/zertosh/dotslash_fixtures"

dotslash/tests/dotslash_tests.rs

Line 704 in 76bbc25

.arg("https://github.com/zertosh/dotslash_fixtures/raw/462625c6bf2671439dce66bd5bc40b05f2ed8819/pack.tar.gz")

[facebook-github-bot]

@zertosh has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[bigfootjon]

@kageiit can you rebase this PR?

[facebook-github-bot]

@zertosh has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[zertosh]

I am conflicted here. I can repro the problem, and I can also repro that switching to binstall_tar fixes at least the ruff extracting issue. BUT, I don't have a lot of confidence in binstall_tar. It looks like they just grabbed the latest alexcrichton/tar-rs and applied (blindly?) many outstanding PRs. I don't know about the quality or how vetted anything has been. I also tried alexcrichton/tar-rs#298 by itself and it addresses the ruff issue too.

@bolinfest, wdyt?

[abhinav]

FWIW, looks like alexcrichton/tar-rs will be maintained again: alexcrichton/tar-rs#379
The sparse files PR was merged 2 weeks ago: alexcrichton/tar-rs#375

[bolinfest]

@abhinav so is a bump to the latest https://crates.io/crates/tar (currently 0.4.42) all that is needed now?

[abhinav]

@abhinav so is a bump to the latest https://crates.io/crates/tar (currently 0.4.42) all that is needed now?

Yes, I believe so, but @kageiit or @zertosh would have to confirm whether their repros are fixed with the upgrade.

[kageiit]

@abhinav so is a bump to the latest https://crates.io/crates/tar (currently 0.4.42) all that is needed now?

Yes, I believe so, but @kageiit or @zertosh would have to confirm whether their repros are fixed with the upgrade.

Let me confirm

[zertosh]

Unfortunately, tar 0.4.42 does not fix this. I just tried it and it fails the same way. I'm still going to update to 0.4.42 since I did the work internally for that anyway

[facebook-github-bot]

This pull request has been merged in 4ee240e.

[zertosh]

This pull request has been merged in 4ee240e.

No no... I just referenced this PR saying that the tar 0.4.42 update doesn't fix the issue