Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix -Wbitwise-instead-of-logical in 5 files starting w/ fbpcs/emp_games/pcf2_attribution/AttributionRule_impl.h #9310

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

r-barnes
Copy link
Contributor

@r-barnes r-barnes commented Jan 5, 2023

Summary:
With LLVM-15, && and || are required for boolean operands, rather than & and | which can be confused for bitwise operations. Fixing such ambiguity helps makes our code more readable.

  • If you approve of this diff, please use the "Accept & Ship" button :-)

Reviewed By: meyering

Differential Revision: D42347735

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D42347735

…es/pcf2_attribution/AttributionRule_impl.h (facebook#9310)

Summary:
Pull Request resolved: facebook#9310

X-link: facebookincubator/dynolog#89

X-link: facebookresearch/fbpcf#462

X-link: facebookresearch/fbpcs#2016

With LLVM-15, `&&` and `||` are required for boolean operands, rather than `&` and `|` which can be confused for bitwise operations. Fixing such ambiguity helps makes our code more readable.

 - If you approve of this diff, please use the "Accept & Ship" button :-)

Differential Revision: D42347735

fbshipit-source-id: 3ec9c8af880cfce6490787662a4c3bc28f990bc7
r-barnes added a commit to r-barnes/fbpcf that referenced this pull request Jan 7, 2023
…es/pcf2_attribution/AttributionRule_impl.h (#9310)

Summary:
X-link: facebook/hhvm#9310

X-link: facebookincubator/dynolog#89

Pull Request resolved: facebookresearch#462

X-link: facebookresearch/fbpcs#2016

With LLVM-15, `&&` and `||` are required for boolean operands, rather than `&` and `|` which can be confused for bitwise operations. Fixing such ambiguity helps makes our code more readable.

 - If you approve of this diff, please use the "Accept & Ship" button :-)

Differential Revision: D42347735

fbshipit-source-id: 44d51851a630d42e8bf9f6a72949399264384e8e
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D42347735

r-barnes added a commit to r-barnes/fbpcs that referenced this pull request Jan 7, 2023
…es/pcf2_attribution/AttributionRule_impl.h (#9310)

Summary:
X-link: facebook/hhvm#9310

X-link: facebookincubator/dynolog#89

X-link: facebookresearch/fbpcf#462

Pull Request resolved: facebookresearch#2016

With LLVM-15, `&&` and `||` are required for boolean operands, rather than `&` and `|` which can be confused for bitwise operations. Fixing such ambiguity helps makes our code more readable.

 - If you approve of this diff, please use the "Accept & Ship" button :-)

Differential Revision: D42347735

fbshipit-source-id: 6e377b3c27cc1fe341e3dfd7d1b4a0adbf236889
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants