Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restart input if imeOptions are changed in TextInputSpec #876

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

martynawieczorek
Copy link
Contributor

Summary

This change modifies TextInputSpec to restart input if imeOptions are changed.
This is needed because if imeOptions are changed when the keyboard is visible, the new imeOptions are not reflected on the keyboard unless restartInput is called. Since there isn't a reliable way to check if the keyboard is visible or not on Android, restartInput should be called whenever imeOptions are changed.

Changelog

Call restartInput if imeOptions are changed in TextInputSpec.

Test Plan

Tested manually. Before the change, changing imeOptions while the keyboard is visible doesn't change the action key to the correct type. After the change, changing imeOptions while the keyboard is visible results in the action key being updated to the correct type. As far as I know, there isn't a way to verify this programatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants